Remove check to delete visit marker only if partition group deleted#7209
Merged
yeya24 merged 3 commits intocortexproject:masterfrom Jan 14, 2026
Merged
Remove check to delete visit marker only if partition group deleted#7209yeya24 merged 3 commits intocortexproject:masterfrom
yeya24 merged 3 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Anna Tran <trananna@amazon.com>
alexqyle
reviewed
Jan 13, 2026
anna-tran
force-pushed
the
fix-visit-marker-deletion
branch
from
024a3e9 to
b72350e
Compare
Signed-off-by: Anna Tran <trananna@amazon.com>
anna-tran
force-pushed
the
fix-visit-marker-deletion
branch
from
b72350e to
cb457ef
Compare
yeya24
approved these changes
Jan 14, 2026
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
Just 1 small comment on the changelog. Otherwise LGTM
Signed-off-by: Anna Tran <trananna@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Removes the additional check that the partition group info file needs to be deleted in order to clean up related visit markers for a complete partition. This check was incorrectly added in https://github.com/cortexproject/cortex/pull/7130/files; the visit markers for a completed plan should always be deleted otherwise they will be left dangling if the partition info file is removed but the rest of the cleaning process is interrupted.
Which issue(s) this PR fixes:
Fixes #7208
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]